1. hakre

    Thanks for the hint, looks quite nice!


  2. Roots | hakre on wordpress

    […] Root (WordPress Theme) via Tavern. […]


  3. Chip Bennett

    Okay, so, I admit to a lack of understanding of the necessity of a lot of what this Theme implements. It’s doing a lot of URL rewriting that serves absolutely no real purpose (changing /wp-content/uploads/ to /assets/, /wp-content/plugins/ to /plugins/, static Theme resources from /wp-content/themes/css/ and /wp-content/themes/js/ to /css/ and /js/, etc.); it considers add_theme_support( 'automatic-feed-links' ) to be “dirty” and instead hard-codes feed links in header.php. It uses add_object_page() (huh?!?) instead of add_theme_page(), registers multiple settings rather than a single options-array DB entry, and appears to perform no validation/sanitization of Theme Settings on input or escaping of Theme Settings on output.

    I like the idea of rock-solid HTML5-based Themes, but this one seems to be less focused on solid WordPress-Theme things, and more focused on non-Theme things.


  4. Ben Word

    You say the URL rewriting serves absolutely no purpose but that’s absolutely incorrect. One of the biggest features of the theme is cleanliness in the code, and that includes getting rid of things like /wp-content/ in URLs.

    See https://github.com/retlehs/roots/issues#issue/5 regarding all your complaints on the theme settings — you can do this if you’d like… I’ve made the issue aware since release that the settings need to be replaced.

    And yes, the default WordPress output of ‘automatic-feed-links’ is dirty along with several other things. The goal is to get as much minimal [HTML5] code output as possible.

    Don’t like it? Fork it..


  5. Chip Bennett

    I’m sorry, but I completely disagree that changing /wp-content/uploads/ to /assets/ in any way whatsoever makes code more “clean”.

    Why try to build in the overhead of the Options Framework Plugin, when you can merely implement the Settings API on your own? (I’d be happy to answer any related questions; I’ve been trying to learn the ins and outs of the Settings API, and would be happy to share.)

    What is “dirty” about ‘automatic-feed-links’? What do you mean by “dirty”?

    Don’t like it? Fork it..

    Totally unnecessary, and I hate when this sentiment is used as a means to stifle debate.


  6. Ben Word

    You don’t have to agree, it’s not your theme.

    Roots was originally called BB — Ben’s Blueprint — I used it only for myself for over a year. I put it out for free to everyone because I thought other people would find it useful (and they have). You don’t have to use it.

    Thanks for your concerns..


  7. Adam J Nowak

    Sometimes innovations are spawned by experimentation


Comments are closed.

%d bloggers like this: