It depends on the audience for the plugin. From a normal end user perspective Wordpress.org is what is needed. Confidence in the code and ease of use of finding and installing etc. are key.

GitHub is great for geeks designing for other geeks.