In reply to Joost de Valk.

Oh shoot. I guess I'm even more forgetful than I thought. My apologies.

But I do stand by my assertion that a block directly modifying the attributes of other blocks is a bad idea. I think that should be implemented at the Heading block. (And speaking of which, if you think you could do that in a PR, please do so. I never wanted to be the only one working on this stuff.)

And quite frankly, I didn't think I had any authority over what you did and didn't do. I'm NOT part of Automattic. I'm not even paid to work on Gutenberg. I'm just some random dude doing this because I genuinely just wanted a good table of contents block in core. If you wanted to create your own Table of Contents block PR, then why would you need my permission?

Sorry if I came off as dismissing you, but all I did (or at least thought I did) was dismiss an implementation idea that sounded unsound to me. I didn't think my comment would be interpreted as some prideful command from on high. Good grief.

If you think there's something inferior about the current implementation, then just open a PR and I'd be happy to review it and give feedback. (But remember that my feedback is only my own.) Heck, maybe your id-generation code could just be (more-or-less) copy-pasted onto the Heading block, depending on how it works.

What makes you think I give a darn whether I invented the table of contents block or not? I don't. I only care about making the implementation perfect, hence why I was hesitant on merging for months because of concerns over hacky PHP code that few other people seemed to care about. If I did care about being "the inventor", I wouldn't have based my PR on someone else's. (And I even created my PR with the intention of it being merged into the other one before the creator of the other PR thought I was better suited to move the development forward.)

Again, I have nothing against Yoast developing a table of contents block, and I didn't know my comment would be taken so seriously. I commented only on the technical soundness I perceived from one dude's comment. I thought updating Heading block ids from the Table of Contents block was a bad idea (and for good reason, considering the undo issues I'd encountered earlier with the block), and so I said I thought it was a bad idea. If anyone disagreed with that, I wish they would have provided a counter-argument. And I wish, if you thought your implementation was better, that you would have just created your own PR.